hg: amber/amber: hooking records to patterns

[Vicente Romero]

Hi,

On 04/06/2018 02:29 PM, Remi Forax wrote:
> I'm Ok with this design for the extractor, exporting the component method handles,
> it's not clear for me why the descriptor is not a method handle corresponding to the primary constructor instead of a method type.

this could be a temporary implementation choice

>
> For the implementation, i suppose it's temporary until it uses a ConstantDynamic instead of an Indy.

correct, once condy are available a condy will be generated instead of 
an indy

> Also Flag.RECORD should be named Flag.EXTRACTOR when applied on a method even if it shares the same value.

yes this could be a self documentation approach

>
> regards,
> Rémi
>
> ----- Mail original -----
>> De: "Vicente Romero" <vicente.romero at oracle.com>
>> À: "amber-dev" <amber-dev at openjdk.java.net>
>> Envoyé: Vendredi 6 Avril 2018 19:01:44
>> Objet: hg: amber/amber: hooking records to patterns
>> Changeset: 829d99f94b43
>> Author:    vromero
>> Date:      2018-04-06 12:28 -0400
>> URL:       http://hg.openjdk.java.net/amber/amber/rev/829d99f94b43
>>
>> hooking records to patterns
>>
>> ! make/autoconf/spec.gmk.in
>> ! src/java.base/share/classes/java/lang/compiler/Extractor.java
>> ! src/java.base/share/classes/module-info.java
>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java
>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java
>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java
>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java