hg: amber/amber: hooking records to patterns

[forax at univ-mlv.fr]

----- Mail original -----
> De: "Vicente Romero" <vicente.romero at oracle.com>
> À: "Remi Forax" <forax at univ-mlv.fr>, "Brian Goetz" <brian.goetz at oracle.com>
> Cc: "amber-dev" <amber-dev at openjdk.java.net>
> Envoyé: Vendredi 6 Avril 2018 20:44:20
> Objet: Re: hg: amber/amber: hooking records to patterns

> Hi,

Hi Vicente,

> 
> On 04/06/2018 02:29 PM, Remi Forax wrote:
>> I'm Ok with this design for the extractor, exporting the component method
>> handles,
>> it's not clear for me why the descriptor is not a method handle corresponding to
>> the primary constructor instead of a method type.
> 
> this could be a temporary implementation choice
> 
>>
>> For the implementation, i suppose it's temporary until it uses a ConstantDynamic
>> instead of an Indy.
> 
> correct, once condy are available a condy will be generated instead of
> an indy

cool !

> 
>> Also Flag.RECORD should be named Flag.EXTRACTOR when applied on a method even if
>> it shares the same value.
> 
> yes this could be a self documentation approach
> 

Rémi