hg: amber/amber: dont generate initialization code if the canonical constructor doesn't completes normally, additional tests

Vicente Romero vicente.romero at oracle.com
Thu Sep 12 20:00:05 UTC 2019


I just did what we are already doing in similar cases like JCCase etc, 
they also have a `completesNormally` field,

Vicente

On 9/10/19 7:21 PM, Jonathan Gibbons wrote:
> Vicente,
>
> The edit to JCTree is questionable for storing semantic info in the 
> AST node. Is there no other way/place to record the information?
>
> -- Jon
>
> On 9/10/19 4:03 PM, vicente.romero at oracle.com wrote:
>> Changeset: 362ffdb9571b
>> Author:    vromero
>> Date:      2019-09-10 19:02 -0400
>> URL: https://hg.openjdk.java.net/amber/amber/rev/362ffdb9571b
>>
>> dont generate initialization code if the canonical constructor 
>> doesn't completes normally, additional tests
>>
>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java
>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java
>> ! test/langtools/tools/javac/records/RecordCompilationTests.java
>>



More information about the amber-dev mailing list