hg: amber/amber: dont generate initialization code if the canonical constructor doesn't completes normally, additional tests

[Vicente Romero]

it could be possible to create a list during the liveness check in Flow 
and then use it during DA/DU analysis and that way we can avoid the new 
field, but given that the field was in use in other trees I didn't saw 
it as a bad idea,

Vicente

On 9/12/19 4:00 PM, Vicente Romero wrote:
> I just did what we are already doing in similar cases like JCCase etc, 
> they also have a `completesNormally` field,
>
> Vicente
>
> On 9/10/19 7:21 PM, Jonathan Gibbons wrote:
>> Vicente,
>>
>> The edit to JCTree is questionable for storing semantic info in the 
>> AST node. Is there no other way/place to record the information?
>>
>> -- Jon
>>
>> On 9/10/19 4:03 PM, vicente.romero at oracle.com wrote:
>>> Changeset: 362ffdb9571b
>>> Author:    vromero
>>> Date:      2019-09-10 19:02 -0400
>>> URL: https://hg.openjdk.java.net/amber/amber/rev/362ffdb9571b
>>>
>>> dont generate initialization code if the canonical constructor 
>>> doesn't completes normally, additional tests
>>>
>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java
>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java
>>> ! test/langtools/tools/javac/records/RecordCompilationTests.java
>>>
>