RFR: 7903857: Include test run in GitHub Actions workflow [v2]

Jaikiran Pai jpai at openjdk.org
Thu Oct 10 10:29:25 UTC 2024


On Thu, 10 Oct 2024 10:19:55 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this change to run APIDiff's self-tests for each pull request.
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix `/bin/sh: 2: set: Illegal option -o pipefail` error

test/junit/JUnitTests.gmk line 44:

> 42: 	$(MKDIR) -p $(@:%.ok=%/work) $(@:%.ok=%/report)
> 43: 	cd $(@:%.ok=%/work) ; \
> 44: 	set -o pipefail ; \

Hello Christian, is this an intentional change on this line?

-------------

PR Review Comment: https://git.openjdk.org/apidiff/pull/25#discussion_r1795156986


More information about the apidiff-dev mailing list