RFR: 7903857: Include test run in GitHub Actions workflow [v2]

Christian Stein cstein at openjdk.org
Thu Oct 10 10:32:22 UTC 2024


On Thu, 10 Oct 2024 10:26:49 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix `/bin/sh: 2: set: Illegal option -o pipefail` error
>
> test/junit/JUnitTests.gmk line 44:
> 
>> 42: 	$(MKDIR) -p $(@:%.ok=%/work) $(@:%.ok=%/report)
>> 43: 	cd $(@:%.ok=%/work) ; \
>> 44: 	set -o pipefail ; \
> 
> Hello Christian, is this an intentional change on this line?

Yes. That `set` leads to:

...
/bin/sh: 2: set: Illegal option -o pipefail
make: *** [../test/junit/JUnitTests.gmk:43: /.../apidiff/build/test/JUnitTests.ok] Error 2
Error: Process completed with exit code 2.

in https://github.com/sormuras/apidiff/actions/runs/11271903419/job/31345716315#step:5:61

-------------

PR Review Comment: https://git.openjdk.org/apidiff/pull/25#discussion_r1795161355


More information about the apidiff-dev mailing list