RFR: repalce stdout by configurable object [v11]
Jiří Vaněk
jvanek at openjdk.org
Sat Oct 15 09:26:08 UTC 2022
On Sat, 15 Oct 2022 09:21:02 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
>> See https://github.com/openjdk/asmtools/pull/38 for full story
>> The PR will be enhanced by handling of two streams in compiler logger. Then the stdout work can continue.
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
>
> Implemented library-like input and output
>
> This commit is adding byte[]/String input/output clasases for direct
> library usage.
> Added tests, advertising how simple is usage of those inputs/outputs
>
> There are two hunks, which fixes issues ovberlooked in previous
> refactorings:
> - traceln now correctly calls getOutputs
> - jdec now uses proper logger insted of accidental stderr
Hello!
This is final logical commit on this topic. if you do not like the changes now, I will be very very sad :)
i think the commit is speaking for itself, how nicely is now j(dis)asm and j(de)coder reusable in libraries.
For non-logical commits I have in mind
- refactor ToolsInput/Output interfaces with many inner classes to separate pkg
- adjust readme.md which will describe library-like usage
- if you would agree, then rename four Main classes to match what they are Main of eg jasm.Main -> jasm.JasmMain - it is super easy to call wrong main.
-------------
PR: https://git.openjdk.org/asmtools/pull/44
More information about the asmtools-dev
mailing list