RFR: repalce stdout by configurable object [v11]

Jiří Vaněk jvanek at openjdk.org
Sun Oct 16 09:24:08 UTC 2022


On Sat, 15 Oct 2022 09:21:02 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> See https://github.com/openjdk/asmtools/pull/38 for full story
>> The PR will be enhanced by handling of two streams in compiler logger. Then the stdout work can continue.
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented library-like input and output
>   
>   This commit is adding byte[]/String  input/output clasases for direct
>   library usage.
>   Added tests, advertising how simple is usage of those inputs/outputs
>   
>   There are two hunks, which fixes issues ovberlooked in previous
>   refactorings:
>    - traceln now correctly calls getOutputs
>    - jdec now uses proper logger insted of accidental stderr

Jsut an idea.. shouldnt:

public static class TextOutput extends NamedToolOutput {
        private final ArrayList<NamedSource> outputs = new ArrayList<>();
        private StringBuilder currentClass;

use  `uEscWriter` as `currentClass` wrapper?? I tried both, but ahve nto spotted difference, so used sting directly

-------------

PR: https://git.openjdk.org/asmtools/pull/44


More information about the asmtools-dev mailing list