RFR: Refactored new ToolInput/Outputs so they reside in own packages and not in original interfaces

Leonid Kuskov lkuskov at openjdk.org
Thu Jan 5 19:36:05 UTC 2023


On Tue, 3 Jan 2023 15:46:53 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

> This PR is refactoring the long interfaces with many inner classes to logical packages.

src/org/openjdk/asmtools/common/inputs/ByteInput.java line 53:

> 51:     public Collection<String> readAllLines() throws IOException {
> 52:         init();
> 53:         ArrayList r = new ArrayList();

Please do use self descriptive names for local vars not just one symbol(except loop's indices)

-------------

PR: https://git.openjdk.org/asmtools/pull/53


More information about the asmtools-dev mailing list