RFR: Refactored new ToolInput/Outputs so they reside in own packages and not in original interfaces

Leonid Kuskov lkuskov at openjdk.org
Thu Jan 5 19:41:11 UTC 2023


On Tue, 3 Jan 2023 15:46:53 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

> This PR is refactoring the long interfaces with many inner classes to logical packages.

src/org/openjdk/asmtools/common/outputs/ByteOutput.java line 34:

> 32: 
> 33:     @Override
> 34:     public void startClass(String fqn, Optional<String> suffix, Environment logger) throws IOException {

fqn isn't informative name. At least method descriptor should be here.

src/org/openjdk/asmtools/common/outputs/ByteOutput.java line 53:

> 51:     public void printlns(String line) {
> 52:         try {
> 53:             currentClass.write((line + "\n").getBytes(StandardCharsets.UTF_8));

Much better to use ` + System.lineSeparator()`

-------------

PR: https://git.openjdk.org/asmtools/pull/53


More information about the asmtools-dev mailing list