RFR: made maven resource plugin and (un)setDetailedOutputOptions expclicit
Jiří Vaněk
jvanek at openjdk.org
Tue Jan 9 14:31:04 UTC 2024
On Thu, 16 Nov 2023 01:52:44 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:
>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes. Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>>
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> The second direction seems more preferable. Since there is no rush, it makes sense to integrate a comprehensive fix for this Maven-Git issue. Thank you very much.
One more test was broken by removal of the reflexive wrappers. IIU the test correclty checking returns from the main calls should be enough. @lkuskov Can you double check the [1d68964](https://github.com/openjdk/asmtools/pull/68/commits/1d68964fe729723291e891eb1d9a92171c0f4e00) commit please?
-------------
PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1883148734
More information about the asmtools-dev
mailing list