RFR: made maven resource plugin and (un)setDetailedOutputOptions expclicit [v5]

[Jiří Vaněk]

On Tue, 9 Jan 2024 14:31:04 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
>> 
>> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adapted SequenceCallsTests to work with return codes rather then with artificial stdout

[ERROR] Failures: 
[ERROR]   JdisJasmTest.jdisJasmAllDecompileCompileAndLoad:35 from 312 failed to assemble  to (/tmp/JdisJasmWorks11256963108958081796) 4: /org/openjdk/asmtools/jasm/Parser.class, /org/openjdk/asmtools/jasm/ClassData.class, /org/openjdk/asmtools/jasm/ClassData$CoreClasses.class, /org/openjdk/asmtools/jasm/ParserCP$ParserCPVisitor.class ==> expected: <0> but was: <4>
[INFO] 
[ERROR] Tests run: 42, Failures: 1, Errors: 0, Skipped: 0



This  fails also from  ide.  those are the two testes which disasm+jasm all classes in asmtools. I had not double chack if it is tstsuite fail or not

failed to assemble  to (/tmp/JdisJasmWorks4524501601177207005) 4:
  /org/openjdk/asmtools/jasm/Parser.class,
  /org/openjdk/asmtools/jasm/ClassData.class,
   /org/openjdk/asmtools/jasm/ClassData$CoreClasses.class,
   /org/openjdk/asmtools/jasm/ParserCP$ParserCPVisitor.class ==> 
Expected :0
Actual   :4



JdisJasmWorks17221649995522723990.java (30:16) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
  public Method this_class:"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell;)V":"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell<*>;)V" 
                ^
JdisJasmWorks17221649995522723990.java (49:16) Error: Either name or Constant Pool index expected, got "<super_class> [86]"
  public Method super_class:"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell;)V":"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell<*>;)V" 
                ^
JdisJasmWorks17221649995522723990.java (68:16) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
  public Method this_class:"(Lorg/openjdk/asmtools/jasm/ConstCell;)V":"(Lorg/openjdk/asmtools/jasm/ConstCell<*>;)V" 
                ^
JdisJasmWorks17221649995522723990.java (88:16) Error: Either name or Constant Pool index expected, got "<super_class> [86]"
  public Method super_class:"(Lorg/openjdk/asmtools/jasm/ConstCell;)V":"(Lorg/openjdk/asmtools/jasm/ConstCell<*>;)V" 
                ^
JdisJasmWorks17221649995522723990.java (108:16) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
  public Method this_class:"()Lorg/openjdk/asmtools/jasm/ConstCell;":"()Lorg/openjdk/asmtools/jasm/ConstCell<*>;" 
                ^
JdisJasmWorks17221649995522723990.java (129:16) Error: Either name or Constant Pool index expected, got "<super_class> [86]"
  public Method super_class:"()Lorg/openjdk/asmtools/jasm/ConstCell;":"()Lorg/openjdk/asmtools/jasm/ConstCell<*>;" 
                ^
6 error(s)
JdisJasmWorks14220440161711403130.java (93:56) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
         invokevirtual     Method ClassData$CoreClasses.this_class:"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell;)V";
                                                        ^
1 error(s)
JdisJasmWorks7075826855074029768.java (6840:56) Error: Either name or Constant Pool index expected, got "<super_class> [86]"
         invokevirtual     Method ClassData$CoreClasses.super_class:"(Lorg/openjdk/asmtools/jasm/ClassData$CoreClasses$PLACE;Lorg/openjdk/asmtools/jasm/ConstCell;)V";
                                                        ^
1 error(s)
JdisJasmWorks7929375517498511475.java (943:56) Error: Either name or Constant Pool index expected, got "<this_class> [85]"
         invokevirtual     Method ClassData$CoreClasses.this_class:"()Lorg/openjdk/asmtools/jasm/ConstCell;";
                                                        ^
1 error(s)
/home/jvanek/git/asmtools/maven/target/classes/org/openjdk/asmtools/jasm/ClassData$CoreClasses.class

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1883183634