<AWT Dev> sun.awt.X11.XEvent is creating 600 MB of char[] for no good reason

Anthony Petrov anthony.petrov at oracle.com
Mon Oct 24 06:22:13 PDT 2011


Hi Federico,

Please correct the code indentation - the lines which get wrapped into 
an if(){} statement need to be moved 4 spaces to the right.

Also, please add a space before each opening { that you're adding.

Otherwise the fix looks good. Thank you! Once you post the final version 
of the patch, I can file a CR for this issue and push the fix to the 
repository.

--
best regards,
Anthony

On 10/22/11 16:23, Federico Tello Gentile wrote:
> El sáb, 22-10-2011 a las 07:47 +0400, Oleg Sukhodolsky escribió:
>> Could you please use curly braces even for one-line ifs.  It looks
>> like it is a part of the style.
>>
>
>
> Sure I can. It is better to do so in my view. I just didn't because they
> are not used in 6 or 7 places in that same class.
>
> Anyway, here's the patch again.
>



More information about the awt-dev mailing list