<AWT Dev> [8] Please review fix for 7177144: [macosx] Drag and drop not working (regression in 7u6)
Anthony Petrov
anthony.petrov at oracle.com
Fri Aug 10 07:50:29 PDT 2012
Alexander,
Please insert a space after 'if' at the following line:
> 437 if(entry.event instanceof SunDropTargetEvent) {
For more details see:
http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-141388.html
section 8.2, point #1.
--
best regards,
Anthony
On 8/10/2012 4:26 PM, Alexander Zuev wrote:
> Hello,
>
> please review my fix for CR 7177144: [macosx] Drag and drop not
> working (regression in 7u6)
>
> I still tink we shouldn't move the instanceof check to the earlier
> stage since this check may be costly
> so it should not be performed unless other possibilities are ruled out
> by the less expensive checks.
>
> Bug description is:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7177144
> Webrev can be found here:
> http://cr.openjdk.java.net/~kizune/7177144/webrev.01
>
> With best regards,
> Alex
More information about the awt-dev
mailing list