<AWT Dev> [8] Please review fix for 7177144: [macosx] Drag and drop not working (regression in 7u6)

Artem Ananiev artem.ananiev at oracle.com
Fri Aug 10 08:41:11 PDT 2012


Hi, Alex,

what about putting the instanceof check to eventToCacheIndex(), under 
MOUSE_DRAGGED switch, and return -1 for dnd events? We don't cache such 
unknown events, as well as don't coalesce them.

Thanks,

Artem

On 8/10/2012 4:26 PM, Alexander Zuev wrote:
> Hello,
>
> please review my fix for CR 7177144: [macosx] Drag and drop not working
> (regression in 7u6)
>
> I still tink we shouldn't move the instanceof check to the earlier stage
> since this check may be costly
> so it should not be performed unless other possibilities are ruled out
> by the less expensive checks.
>
> Bug description is:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7177144
> Webrev can be found here:
> http://cr.openjdk.java.net/~kizune/7177144/webrev.01
>
> With best regards,
> Alex



More information about the awt-dev mailing list