<AWT Dev> Request for review: 7154778 - NSView-based embedded frame

[Sergey Bylokhov]

Hi, Petr.
Just a few minor issues after quick look:
1 Seems that getPeerType() should be in LWWindowsPeer class not in 
CPlatformWindow.
2 New line number 333 in LWWindowPeer.java is too long
3 There is a way to unify nativeIsViewUnderMouse and 
nativeIsWindowUnderMouse? Because both methods checks a point in nsview.
4 Probably we shall replace performOnMainThread  on 
AWT_PERFORM_ON_MAIN_THREAD_WAITING  everywhere?
5 Where CPlatformView.setAutoResizable is used?
6 CViewPlatformEmbeddedFrame could cache the native bounds, like 
CPWindows does? in this way CPlatformView.nativeGetLocationOnScreen is 
unnecessary.
7 Why we need override resizeWithOldSuperviewSize() in AWTView? How it 
work in the usual way when we use AWTWindow windowDidResize/windowDidMove?
8 Also please update webrev to the latest version of workspace.

27.11.2012 13:55, Petr Pchelko wrote:
> Hello, AWT team.
>
> please, review the following fix for 7154778:
>
> http://cr.openjdk.java.net/~art/pchelko/7154778/ 
> <http://cr.openjdk.java.net/%7Eart/pchelko/7154778/>
>
> The bug description and evaluation is available here:
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154778
>
> To work with the new EmbeddedFrame implementation, existing code (e.g. 
> SWT) needs to be modified to use sun.lwawt.macosx.CViewEmbeddedFrame 
> class instead of Apple's apple.awt.CEmbeddedFrame.
> Here is the corresponding patch for SWT:
>
> http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt 
> <http://cr.openjdk.java.net/%7Eart/pchelko/7154778/swt_patch.txt>
>
>
> Best, Petr Pchelko


-- 
Best regards, Sergey.