<AWT Dev> Request for review: 7154778 - NSView-based embedded frame

[Leonid Romanov]

Hi,
I don't quite understand some focus related changes you've made. What is the reason for generating focus events from - (BOOL) becomeFirstResponder and - (BOOL) resignFirstResponder? There are - (void) windowDidBecomeKey and - (void) windowDidResignKey methods in AWTWindow we've been using to generate focus events from, so I'm afraid that with your change will be getting duplicate focus events.  

Leonid.  


On Nov 27, 2012, at 1:55 PM, Petr Pchelko <petr.pchelko at oracle.com> wrote:

> Hello, AWT team.
> 
> please, review the following fix for 7154778:
> 
> http://cr.openjdk.java.net/~art/pchelko/7154778/
> 
> The bug description and evaluation is available here:
> 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7154778
> 
> To work with the new EmbeddedFrame implementation, existing code (e.g. SWT) needs to be modified to use sun.lwawt.macosx.CViewEmbeddedFrame class instead of Apple's apple.awt.CEmbeddedFrame. 
> Here is the corresponding patch for SWT:
> 
> http://cr.openjdk.java.net/~art/pchelko/7154778/swt_patch.txt
> 
> 
> Best, Petr Pchelko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20121127/d5fda1eb/attachment.html