<AWT Dev> [9] Review request for 8029979: Allow multiple calls to DropTargetDropEvent.acceptDrop()

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Dec 13 15:14:48 PST 2013


Hi, Anthony
Me surprises why fx calls this method several time.
Is it necessary to check !dropComplete? Probabbly acceptDrop should be 
noop in case of dropStatus  == STATUS_ACCEPT?
I guess the same change can be applied to the rejectDrop?

On 13.12.2013 20:53, Anthony Petrov wrote:
> Hi Petr, Sergey,
>
> Please review a fix for 
> https://bugs.openjdk.java.net/browse/JDK-8029979 at:
>
> http://cr.openjdk.java.net/~anthony/8-3-acceptDrop-8029979.0/
>
> I enable calling SunDropTargetContextPeer.acceptDrop() as many times 
> as needed, for as long as the DnD operation isn't complete yet. 
> Running open and closed DnD regression tests revealed no new failures.
>
> Note that later we will need to back-port this fix to 8u20.
>
> -- 
> best regards,
> Anthony


-- 
Best regards, Sergey.



More information about the awt-dev mailing list