<AWT Dev> [9] Review request for 8029979: Allow multiple calls to DropTargetDropEvent.acceptDrop()

Petr Pchelko petr.pchelko at oracle.com
Mon Dec 16 06:30:34 PST 2013


Hello, Anthony.

The fix look good.

With best regards. Petr.

On 16.12.2013, at 18:22, Anthony Petrov <anthony.petrov at oracle.com> wrote:

> Hi Petr,
> 
> Thank you for the review. Please find a webrev with a new regression test included at:
> 
> http://cr.openjdk.java.net/~anthony/8-3-acceptDrop-8029979.1/
> 
> --
> best regards,
> Anthony
> 
> On 12/14/2013 03:07 AM, Petr Pchelko wrote:
>> Hello, Anthony.
>> 
>> The code changes look good, but could you please add a reg test for this issue.
>> 
>> With best regards. Petr.
>> 
>> On Dec 13, 2013, at 8:53 PM, Anthony Petrov <anthony.petrov at oracle.com> wrote:
>> 
>>> Hi Petr, Sergey,
>>> 
>>> Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8029979 at:
>>> 
>>> http://cr.openjdk.java.net/~anthony/8-3-acceptDrop-8029979.0/
>>> 
>>> I enable calling SunDropTargetContextPeer.acceptDrop() as many times as needed, for as long as the DnD operation isn't complete yet. Running open and closed DnD regression tests revealed no new failures.
>>> 
>>> Note that later we will need to back-port this fix to 8u20.
>>> 
>>> --
>>> best regards,
>>> Anthony
>> 



More information about the awt-dev mailing list