<AWT Dev> [8] Review request for 8000425: FileDialog documentation should be enhanced

[Oleg Pekhovskiy]

Hi Anthony,

thank you for the review...

Please, review the second version of fix here:
http://cr.openjdk.java.net/~bagiras/8000425.2/

and my comments below...

Thanks,
Oleg

On 25.09.2013 16:12, Anthony Petrov wrote:
> Hi Oleg,
>
> I suggest to rephrase the statements as follows:
>
>>  460      * The file could be highlighted or its name could be entered
>> depending on
>>  461      * native file dialog implementation.
>
> "When the dialog is shown, the specified file is selected. The kind of
> selection depends on the dialog type and the native platform. For
> example, the file could be highlighted in the file list, or a file name
> editbox could be populated with a string containing the specified file
> name."
I borrowed your modification, plus mentioned 'file existence' as one of 
the dependencies.
>
>>  463      * This method accepts full path or file name with extension
>> when used
>>  464      * together with <code>setDirectory()</code> method.
>
> "This method accepts either a full file path, or a file name with an
> extension if used together with the {@code setDirectory} method."
>
>>  467      * <code>null</code> as the file.
>
> {@code null}
Borrowed too.

>
>
> Please get a CCC approval before pushing this fix.
>
> --
> best regards,
> Anthony
>
> On 09/25/2013 02:50 PM, Oleg Pekhovskiy wrote:
>> Hi all,
>>
>> please review the fix
>> http://cr.openjdk.java.net/~bagiras/8000425.1/
>> for
>> https://bugs.openjdk.java.net/browse/JDK-8000425
>>
>> It's just a Javadoc fix.
>>
>> Thanks,
>> Oleg