<AWT Dev> [8] Request for review: 8025603 Unused methods in the awt text peers should be removed

Artem Ananiev artem.ananiev at oracle.com
Mon Oct 7 10:06:52 PDT 2013


Nice cleanup, now looks fine. Let us see what will be broken, as it 
usually happens with most of cleanups :)

Thanks,

Artem

On 10/7/2013 7:19 PM, Sergey Bylokhov wrote:
> Hi, Artem.
> Thanks for review.
> Updated version:
> http://cr.openjdk.java.net/~serb/8025603/webrev.01
>
> WComponentPeer.minimumSize also removed, because it is never used in
> java or in native.
>
> On 07.10.2013 18:03, Artem Ananiev wrote:
>> Hi, Sergey,
>>
>> the changes look fine.
>>
>> Could you also remove deprecated methods in WTextArea, e.g.
>> insertText(), since you touch these files anyway, please?
>>
>> Thanks,
>>
>> Artem
>>
>> On 10/2/2013 10:38 PM, Sergey Bylokhov wrote:
>>> Hello,
>>> Please review the fix for jdk 8. This is a code cleanup.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8025603
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/8025603/webrev.00
>>>
>
>


More information about the awt-dev mailing list