<AWT Dev> [8] Review request for 8025438 [macosx] right JNFCall* method should be used in JDK-8008728 fix

Anthony Petrov anthony.petrov at oracle.com
Wed Sep 25 10:56:08 PDT 2013


Looks fine.

--
best regards,
Anthony

On 09/25/2013 07:07 PM, Alexander Scherbatiy wrote:
> Hello,
>
> Could you review the fix:
>    bug: https://bugs.openjdk.java.net/browse/JDK-8025438
>    webrev: http://cr.openjdk.java.net/~alexsch/8025438/webrev.00
>
>    See
> http://mail.openjdk.java.net/pipermail/awt-dev/2013-September/005508.html
>
>    - The JNFCallVoidMethod is changed to JNFCallBooleanMethod
>    -'if' block is formatted
>
>    The following comment is already added by the JDK-8008728 fix
>    -------------------
>    // Native system can bring up the NSWindow to
>    // the top even if the window is not main.
>    // We should bring up the modal dialog manually
>    -------------------
>
> Thanks,
> Alexandr.
>


More information about the awt-dev mailing list