<AWT Dev> [8] Review request for 8025438 [macosx] right JNFCall* method should be used in JDK-8008728 fix

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Sep 25 11:12:51 PDT 2013


Hi, Alexander.
The fix looks good.

On 25.09.2013 19:07, Alexander Scherbatiy wrote:
> Hello,
>
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8025438
>   webrev: http://cr.openjdk.java.net/~alexsch/8025438/webrev.00
>
>   See 
> http://mail.openjdk.java.net/pipermail/awt-dev/2013-September/005508.html
>
>   - The JNFCallVoidMethod is changed to JNFCallBooleanMethod
>   -'if' block is formatted
>
>   The following comment is already added by the JDK-8008728 fix
>   -------------------
>   // Native system can bring up the NSWindow to
>   // the top even if the window is not main.
>   // We should bring up the modal dialog manually
>   -------------------
>
> Thanks,
> Alexandr.
>


-- 
Best regards, Sergey.



More information about the awt-dev mailing list