<AWT Dev> [8] Review request for CR JDK-8025218 [javadoc] some errors in java/awt classes

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Sep 27 03:45:08 PDT 2013


Hi, Yuri.
According to our process all fixes require 2 reviewers and one of them 
should be reviewer in the jdk 8 project.

On 27.09.2013 14:33, Yuri Nesterenko wrote:
> Hi Anthony,
>
> alas, fix is already in the gate.
>
> We will soon have, however, a proper Manual of Style, fortified with
> doclint and requiring HTML 5 compliance etc., and there will be
> another fixing campaign.
>
> Thanks,
> -yan
>
>
> On 09/27/2013 02:22 PM, Anthony Petrov wrote:
>> Hi Dmitry,
>>
>> While you're at it, could you also replace <code>...</code> with {@code
>> ...} at lines that you're changing anyway. E.g.:
>>
>> src/share/classes/java/awt/DefaultKeyboardFocusManager.java
>>> -     * <code>enqueueKeyEvents</code>, or any value < 0
>>> +     *        <code>enqueueKeyEvents</code>, or any value &lt; 0
>>
>> Here, {@code enqueueKeyEvents} would look better. Etc. Please don't
>> update lines that aren't modified in your fix already.
>>
>> Also, I second to Yuri, you don't need a <code> (or {@code}) tag within
>> <pre></pre> (in e.g. SystemTray.java).
>>
>> -- 
>> best regards,
>> Anthony
>>
>> On 09/26/2013 12:25 PM, Dmitry Zinkevich wrote:
>>> Hello everybody,
>>>
>>> please, review my changes to javadoc in awt classes.
>>>
>>> Bug with classes listed: 
>>> https://bugs.openjdk.java.net/browse/JDK-8025218
>>> Review request:
>>> http://cr.openjdk.java.net/~alexsch/dmitry-zinkevich/8025218/
>>>
>


-- 
Best regards, Sergey.



More information about the awt-dev mailing list