<AWT Dev> [8] Review request for CR JDK-8025218 [javadoc] some errors in java/awt classes

[Yuri Nesterenko]

Hi Sergey,

I specifically asked Artem about that, and he said that formally,
process does require one reviewer; good practice and his personal
usual demand is two; for fixes like that one is OK.
According to the census, I'm still jdk8 reviewer.

Thanks,
-yan

On 09/27/2013 02:45 PM, Sergey Bylokhov wrote:
> Hi, Yuri.
> According to our process all fixes require 2 reviewers and one of them
> should be reviewer in the jdk 8 project.
>
> On 27.09.2013 14:33, Yuri Nesterenko wrote:
>> Hi Anthony,
>>
>> alas, fix is already in the gate.
>>
>> We will soon have, however, a proper Manual of Style, fortified with
>> doclint and requiring HTML 5 compliance etc., and there will be
>> another fixing campaign.
>>
>> Thanks,
>> -yan
>>
>>
>> On 09/27/2013 02:22 PM, Anthony Petrov wrote:
>>> Hi Dmitry,
>>>
>>> While you're at it, could you also replace <code>...</code> with {@code
>>> ...} at lines that you're changing anyway. E.g.:
>>>
>>> src/share/classes/java/awt/DefaultKeyboardFocusManager.java
>>>> -     * <code>enqueueKeyEvents</code>, or any value < 0
>>>> +     *        <code>enqueueKeyEvents</code>, or any value &lt; 0
>>>
>>> Here, {@code enqueueKeyEvents} would look better. Etc. Please don't
>>> update lines that aren't modified in your fix already.
>>>
>>> Also, I second to Yuri, you don't need a <code> (or {@code}) tag within
>>> <pre></pre> (in e.g. SystemTray.java).
>>>
>>> --
>>> best regards,
>>> Anthony
>>>
>>> On 09/26/2013 12:25 PM, Dmitry Zinkevich wrote:
>>>> Hello everybody,
>>>>
>>>> please, review my changes to javadoc in awt classes.
>>>>
>>>> Bug with classes listed:
>>>> https://bugs.openjdk.java.net/browse/JDK-8025218
>>>> Review request:
>>>> http://cr.openjdk.java.net/~alexsch/dmitry-zinkevich/8025218/
>>>>
>>
>
>