<AWT Dev> Review request: JDK-8055197 TextField deletes multiline strings

[Sergey Bylokhov]

On 18.09.15 19:14, Phil Race wrote:
> Quick question: is this behaviour you are specifying and enforcing
> already the
> existing behaviour on all other platforms we support  (ie
> linux,solaris,macosx) ?


Note that the fix replace the eol char on the peer level. So there will 
be a difference in behavior of setText/GetText when the peer exists or not.

ps. You should send each new review request as a new email, otherwise 
your email will be filtered to the previous request. See your emails:
http://mail.openjdk.java.net/pipermail/awt-dev/2015-September/thread.html

>
> And what about Label ? It should also be the same for Label on all
> platforms.
>
> Also small though they are, the additional words in TextField's javadoc
> will require a CCC request. That is currently (still!) an internal process.
> We can help you out with that.
>
> -phil.
>
> On 09/18/2015 07:41 AM, Ambarish Rapte wrote:
>>
>> Hi,
>>
>> Please review the following fix for jdk9.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8055197
>>
>> Webrev:
>> http://cr.openjdk.java.net/~psadhukhan/ambarish/8055197/webrev.00/
>> <http://cr.openjdk.java.net/%7Epsadhukhan/ambarish/8055197/webrev.00/>
>>
>> Issue://
>>
>> -/If text containing new line character is set to TextField,//Text
>> after new line character was terminated./
>>
>> -/Issue occurs only on windows./
>>
>> Cause:
>>
>> -For windows new line character is   ‘\r\n’.
>>
>> -For windows code this new line character was not replaced by space
>> character.
>>
>> Fix:
>>
>> -Declared a new virtual method /RemoveEOL()/ in a/wt_TextComponent.h/
>> similar to /RemoveCR()/
>>
>> -Implemented this /RemoveEOL()/  method only for a/wt_TextField,
>> / which will remove ‘\r\n’ from input string for TextField
>>
>> Many Thanks,
>> Ambarish Rapte
>>
>


-- 
Best regards, Sergey.