<AWT Dev> [9] Review request for JDK-8145174 HiDPI splash screen support on Linux

Rajeev Chamyal rajeev.chamyal at oracle.com
Fri Feb 12 12:21:45 UTC 2016


Hello All,

 

Could you please review the following fix.

Bug : https://bugs.openjdk.java.net/browse/JDK-8145174

Webrev : http://cr.openjdk.java.net/~rchamyal/8145174/webrev.00/

 

This is an enhancement to support HiDPI splash screen on Linux.

As a part of this enhancement implementation to splashscreen_sys.c::SplashGetScaledImageName method has been provided based on the GDK_SCALE environment variable set on unix/linux system.

The new implementation checks for GDK_SCALE set on system and returns the scaled image name, if GDK_SCALE=2 otherwise NULL.

The naming convention followed for scaled image is as follows:

 

Unscaled image name : image.ext

Scaled image name : image.java-scale2x.ext

 

The automated jtreg test for this is currently failing due to issues in robot.getPixelColor it is returning wrong pixel color for GDK_SCALE=2.

 

Also fixed issues in following files.

1)      splashscreen_impl.c::SplashInit() was resetting the scaleFactor to 1.

2)      SplashScreen.java:: getBounds fixed the typo.

 

Regards,

Rajeev Chamyal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20160212/5ad2b317/attachment.html>


More information about the awt-dev mailing list