<AWT Dev> Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

[Sergey Bylokhov]

The fix looks fine. Small notes about the test:
  - Probably it will be better to increase the height of the instruction 
to eliminate the vertical scroll?
  - The typo: 67 "Mouse press on te TextField text",

On 11.02.16 12:23, Ambarish Rapte wrote:
> Hi,
>
>                  Please review the fix for JDK9,
>
>                  Bug: https://bugs.openjdk.java.net/browse/JDK-8149636
>
>                  Webrev:
> http://cr.openjdk.java.net/~arapte/8149636/webrev.00/
>
> Issue:
>
>                  While scrolling with selection, when mouse is dragged
> outside the bounds of TextField,
>
> a.TextField flickering is observed
>
> b.TextField over scrolls on right. Text gets hidden on left side even
> when no scroll is needed.
>
> Cause:
>
> a.Flicker –
> For simulating scroll, scroll bar information is used.
> To get correct scroll info, scroll bar should be visible.
> Showing and hiding of scroll bar causes the flickering.
>
> b.Over Scroll –
>
> The scrolling logic scrolled the textField in units of half the
> si.nPage. i.e. (si.inPage / 2) maximum till si.nMax,
> Which causes the over scroll.
>
> Fix:
>
>                  ES_AUTOHSCROLL set for the TextField enables the
> automatic horizontal scrolling, so we need not add code for scrolling.
>
>                  Only selection should be updated as the mouse moves.
>
>                  Hence removed the code to related to SendMessage(
> WM_HSCROLL,…)  i.e. scrolling
>
> Verification:
>
>                  Manually Verified that textField editing / selection /
> copy / paste works fine.
>
>                  No Jtreg, JCK tests related to TextField fail due to
> this change.
>
>                  Updated an existing test *ScrollSelectionTest.java *to
> test the scenarios mentioned in the bug.
>
> Thanks,
>
> Ambarish
>


-- 
Best regards, Sergey.