<AWT Dev> [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Alexander Stepanov
alexander.v.stepanov at oracle.com
Fri Mar 4 16:08:26 UTC 2016
The test should be updated to cover the related issue
https://bugs.openjdk.java.net/browse/JDK-8151303
Regards,
Alexander
On 3/4/2016 1:15 PM, Alexander Stepanov wrote:
> Hello, Sergey,
>
> We have JLabel(icon) already in the test, and we cannot have both
> these cases at the same tab. Moreover, we can in principle use some
> other components as an argument of 'setTabComponentAt', but I'm not
> sure that these cases have some novelty.
>
> So my suggestion is to can simply return to the old version of the
> test (which will fail on OS X) or add it commented with some "TODO:
> uncomment / replace after 8151060 fix" instruction in code.
>
> Thanks,
> Alexander
>
> On 3/4/2016 1:21 AM, Sergey Bylokhov wrote:
>> Hi, Alexander.
>> I suggest to add these lines to the test instead of replace the old
>> lines. The test will pass after the fix for 8151060.
>>
>> On 03.03.16 17:45, Alexander Stepanov wrote:
>>> Could you please review the updated version of the test?
>>> http://cr.openjdk.java.net/~avstepan/8150724/webrev.01
>>>
>>> Line
>>> 106 tabbedPane.addTab("", icon, p);
>>> was replaced with
>>> 109 tabbedPane.addTab("", p);
>>> 110 tabbedPane.setTabComponentAt(0, new JLabel(icon));
>>>
>>> - in such a case the test passes for OS X (as well as for Windows,
>>> Linux).
>>> Probably these changes should be reverted after JDK-8151060 fix.
>>>
>>> Thanks,
>>> Alexander
>>>
>>> On 3/2/2016 7:15 PM, Alexander Stepanov wrote:
>>>> Hello Sergey,
>>>>
>>>> It fails because of
>>>> https://bugs.openjdk.java.net/browse/JDK-8151060
>>>>
>>>> (plus we need here some tricky check for resolution by the analogy
>>>> with 8150258 because of JDK-8150844).
>>>>
>>>> Thanks,
>>>> Alexander
>>>>
>>>> On 2/26/2016 4:25 PM, Sergey Bylokhov wrote:
>>>>> Hi, Alexander.
>>>>> The test failed on osx 10.11 + retina. Is it expected?
>>>>>
>>>>> On 26.02.16 15:53, Alexander Stepanov wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Could you please review the following fix
>>>>>> http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/
>>>>>> for
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8150724 ?
>>>>>>
>>>>>> Just a single test added.
>>>>>>
>>>>>> Thanks,
>>>>>> Alexander
>>>>>
>>>>>
>>>>
>>>
>>
>>
>
More information about the awt-dev
mailing list