<AWT Dev> Review-request for 8143227: Platform-Specific Desktop Features

[Mandy Chung]

> On Mar 5, 2016, at 1:48 AM, Alexander Zvegintsev <alexander.zvegintsev at oracle.com> wrote:
> 
> Fixed: http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/09/

modules.xml change looks fine.  Thanks for the update.

Mandy

> 
> --
> Thanks,
> Alexander.
> 
> On 03/05/2016 04:10 AM, Mandy Chung wrote:
>>> On Mar 4, 2016, at 11:07 AM, Phil Race <philip.race at oracle.com> wrote:
>>> 
>>> Approved.
>>> 
>>> -phil.
>>> 
>>> One comment on something you can't do anything about *yet*, is
>>> that adding a new API package right in the same time frame jigsaw is
>>> merging in to JDK9 creates a probable time window for a non-obvious conflict.
>>> 
>>> See http://cr.openjdk.java.net/~alanb/8142968/0/jdk/src/java.desktop/share/classes/module-info.java.html
>>> where java.awt.desktop will need to be added to the list of exported packages.
>> 
>> I don’t see modules.xml updated from this webrev:
>> 
>>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/08/
>> Please update <top>/modules.xml to export java.awt.desktop if present (it’s an interim solution in JDK 9 that will be replaced with module-info.java as Phil points out).  When we merge jake with jdk9, we make appropriate changes based on the changeset in modules.xml.
>> 
>> Mandy
>> 
>