<AWT Dev> RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v5]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Thu Dec 17 10:04:01 UTC 2020


On Mon, 14 Dec 2020 21:31:15 GMT, Phil Race <prr at openjdk.org> wrote:

>> This defines some macros to support declaring and initialising statically allocated instances of jclass, jmethodID and jfieldID
>> and changes many existing uses of JNF macros/functions to use these instead.
>> Then calls to JNFCall* and JNFNewObject - etc are updated to directly call JNI methods
>> JNI exception checking macros are added as needed.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code

src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m line 595:

> 593:     if (peer == NULL) {
> 594:         NSLog(@"Apple AWT : Error AWTView:awtComponent got null peer from CPlatformView");
> 595:         JNFDumpJavaStack(env);

and this JNFDumpJavaStack?

src/java.desktop/macosx/native/libawt_lwawt/awt/ApplicationDelegate.m line 319:

> 317: 
> 318:     for (NSString *filename in filenames) {
> 319:         jstring jFileName = JNFNormalizedJavaStringForPath(env, filename);

JNFNormalizedJavaStringForPath?

src/java.desktop/macosx/native/libosxui/ScreenMenu.m line 148:

> 146: 
> 147:     JNIEnv *env = [ThreadUtilities getJNIEnv];
> 148: JNF_COCOA_ENTER(env);

what about this macros JNF_COCOA_ENTER/EXIT?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1679


More information about the awt-dev mailing list