<AWT Dev> RFR: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code [v5]

[Phil Race]

On Thu, 17 Dec 2020 09:52:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/ApplicationDelegate.m line 293:
> 
>> 291:     //fprintf(stderr,"jm_handleOpenURL\n");
>> 292:     JNIEnv *env = [ThreadUtilities getJNIEnv];
>> 293:     jstring jURL = JNFNSToJavaString(env, url);
> 
> Don't we need to remove this JNFNSToJavaString dependancy?

Not for these changes. There will be a subsequent patch to update all of the string conversions

> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m line 595:
> 
>> 593:     if (peer == NULL) {
>> 594:         NSLog(@"Apple AWT : Error AWTView:awtComponent got null peer from CPlatformView");
>> 595:         JNFDumpJavaStack(env);
> 
> and this JNFDumpJavaStack?

It will get removed eventually when we stop importing JavaNativeFoundation but does not need to be removed yet

> src/java.desktop/macosx/native/libawt_lwawt/awt/ApplicationDelegate.m line 319:
> 
>> 317: 
>> 318:     for (NSString *filename in filenames) {
>> 319:         jstring jFileName = JNFNormalizedJavaStringForPath(env, filename);
> 
> JNFNormalizedJavaStringForPath?

Another one for a later patch

> src/java.desktop/macosx/native/libosxui/ScreenMenu.m line 148:
> 
>> 146: 
>> 147:     JNIEnv *env = [ThreadUtilities getJNIEnv];
>> 148: JNF_COCOA_ENTER(env);
> 
> what about this macros JNF_COCOA_ENTER/EXIT?

All these things you ask about will be in a follow on patch. I thought I had made clear this is nOT
the whole thing - for starters I haven't removed the imports

-------------

PR: https://git.openjdk.java.net/jdk/pull/1679