[code-reflection] RFR: Refactor JavaType [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Apr 9 08:15:15 UTC 2024


On Mon, 8 Apr 2024 20:05:10 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment
>
> src/java.base/share/classes/java/lang/reflect/code/op/CoreOps.java line 1605:
> 
>> 1603:             if (!arrayType.isArray()) {
>> 1604:                 throw new IllegalArgumentException("Type is not an array type: " + arrayType);
>> 1605:             }
> 
> Suggestion:
> 
>             if (!(array.type() instanceof ArrayType arrayType)) {
>                 throw new IllegalArgumentException("Type is not an array type: " + array.type());
>             }
> 
> ?

How do I build the examples, and make sure everything is ok?

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/46#discussion_r1557178155


More information about the babylon-dev mailing list