[code-reflection] RFR: Refactor JavaType [v3]

[Maurizio Cimadamore]

On Tue, 9 Apr 2024 08:12:30 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/reflect/code/op/CoreOps.java line 1605:
>> 
>>> 1603:             if (!arrayType.isArray()) {
>>> 1604:                 throw new IllegalArgumentException("Type is not an array type: " + arrayType);
>>> 1605:             }
>> 
>> Suggestion:
>> 
>>             if (!(array.type() instanceof ArrayType arrayType)) {
>>                 throw new IllegalArgumentException("Type is not an array type: " + array.type());
>>             }
>> 
>> ?
>
> How do I build the examples, and make sure everything is ok?

Ok, I found the POM files. Note: the SPIR-V project doesn't build, as the POM depends on version 0.3 of `beehive-spirv-toolkit`, but when installing that package locally, the build ends up with 0.4 (I guess the source has been updated in the meantime).

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/46#discussion_r1557609877