[code-reflection] RFR: Bytecode round 10 [v2]

Adam Sotona asotona at openjdk.org
Fri Aug 16 05:41:13 UTC 2024


On Thu, 15 Aug 2024 21:19:37 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java
>>   
>>   Co-authored-by: Chen Liang <liach at openjdk.org>
>
> src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java line 1124:
> 
>> 1122:                 load(value);
>> 1123:             }
>> 1124:         } else if (target.predecessors().size() > (target.isEntryBlock() ? 0 : 1)) {
> 
> An entry block cannot have any predecessors. Are you observing that? If so its a bug.

Right, it does not happen.
I added it intuitively as looping to bci 0 is frequent in the bytecode.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/215#discussion_r1719345345


More information about the babylon-dev mailing list