[code-reflection] RFR: Bytecode round 10 [v3]

[Paul Sandoz]

On Fri, 16 Aug 2024 05:38:08 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java line 1124:
>> 
>>> 1122:                 load(value);
>>> 1123:             }
>>> 1124:         } else if (target.predecessors().size() > (target.isEntryBlock() ? 0 : 1)) {
>> 
>> An entry block cannot have any predecessors. Are you observing that? If so its a bug.
>
> Right, it does not happen.
> I added it intuitively as looping to bci 0 is frequent in the bytecode.

Interesting. I suppose when lifting such cases you have to create a block (with possible parameters) that the entry block unconditionally branches too.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/215#discussion_r1720068613