[code-reflection] RFR: throw instead returning when erasing checked to unchecked exception [v2]

[Paul Sandoz]

On Thu, 18 Jan 2024 08:40:09 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

>> As discussed in https://mail.openjdk.org/pipermail/babylon-dev/2024-January/000006.html, I change the `erase` method to `eraseAndThrow` and added a test as suggested. I ensured that the test fails without my change and does not fail with it.
>
> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address comments

Very good, thank you for doing this.

-------------

Marked as reviewed by psandoz (Reviewer).

PR Review: https://git.openjdk.org/babylon/pull/2#pullrequestreview-1830145616