[code-reflection] RFR: Skip bytecode dialect

Hannes Greule hgreule at openjdk.org
Mon Jan 29 16:52:52 UTC 2024


On Mon, 29 Jan 2024 15:52:29 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> This is the first step to avoid custom bytecode dialect. Second step will be to rewrite BytecodeLift. 
> 
> BytecodeGenerator now consumes CoreOps and generates bytecode directly.
> 
> Two try-finally test cases are disabled due to invalid structure (missing exception.region.exit for some finalizers).
> All other tests are passing.
> 
> Calculation of try-catch regions is still very raw and needs some future improvements. 
> 
> Please review.
> 
> Thanks,
> Adam

src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java line 443:

> 441: 
> 442:             // Assign slots to block arguments
> 443:             b.parameters().forEach(c::getOrAssignSlot);

This has the same problem as the one #8 fixes. You can probably include the changes from that PR here directly.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/9#discussion_r1469897291


More information about the babylon-dev mailing list