[code-reflection] RFR: Skip bytecode dialect [v2]

Adam Sotona asotona at openjdk.org
Tue Jan 30 16:18:02 UTC 2024


On Mon, 29 Jan 2024 16:50:13 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>> 
>>  - Merge branch 'code-reflection' into skip-bytecode-dialect
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeLower.java
>>  - removed BytecodeLower
>>  - disabled failing tests
>>  - work in progress
>>  - work in progress
>>  - work in progress
>>  - work in progress
>>  - work in progress
>
> src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java line 443:
> 
>> 441: 
>> 442:             // Assign slots to block arguments
>> 443:             b.parameters().forEach(c::getOrAssignSlot);
> 
> This has the same problem as the one #8 fixes. You can probably include the changes from that PR here directly.

Yes, I'm going to include the fix.
Thanks!

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/9#discussion_r1471387813


More information about the babylon-dev mailing list