[code-reflection] RFR: Skip bytecode dialect
Adam Sotona
asotona at openjdk.org
Tue Jan 30 16:18:02 UTC 2024
On Mon, 29 Jan 2024 15:52:29 GMT, Adam Sotona <asotona at openjdk.org> wrote:
> This is the first step to avoid custom bytecode dialect. Second step will be to rewrite BytecodeLift.
>
> BytecodeGenerator now consumes CoreOps and generates bytecode directly.
>
> Two try-finally test cases are disabled due to invalid structure (missing exception.region.exit for some finalizers).
> All other tests are passing.
>
> Calculation of try-catch regions is still very raw and needs some future improvements.
>
> Please review.
>
> Thanks,
> Adam
I would prefer to merge this partial work and continue with `computeExceptionRegionMembership` later, when the lowering correctly marks all region exits and I will be able to verify the calculation with the tests.
Thanks!
BTW I'm also considering to remove various inlined custom optimizations (like for example custom code skipping redundant branches to immediately following labels).
And introduce a central optimizing `CodeTransform` instead. It will do the same job in one place, based on patterns to optimize.
-------------
PR Comment: https://git.openjdk.org/babylon/pull/9#issuecomment-1917108095
PR Comment: https://git.openjdk.org/babylon/pull/9#issuecomment-1917188187
More information about the babylon-dev
mailing list