[code-reflection] RFR: Skip bytecode dialect [v2]

Paul Sandoz psandoz at openjdk.org
Tue Jan 30 17:23:48 UTC 2024


On Tue, 30 Jan 2024 16:18:02 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> This is the first step to avoid custom bytecode dialect. Second step will be to rewrite BytecodeLift. 
>> 
>> BytecodeGenerator now consumes CoreOps and generates bytecode directly.
>> 
>> Two try-finally test cases are disabled due to invalid structure (missing exception.region.exit for some finalizers).
>> All other tests are passing.
>> 
>> Calculation of try-catch regions is still very raw and needs some future improvements. 
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Merge branch 'code-reflection' into skip-bytecode-dialect
>    
>    # Conflicts:
>    #	src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeLower.java
>  - removed BytecodeLower
>  - disabled failing tests
>  - work in progress
>  - work in progress
>  - work in progress
>  - work in progress
>  - work in progress

Marked as reviewed by psandoz (Lead).

-------------

PR Review: https://git.openjdk.org/babylon/pull/9#pullrequestreview-1851921196


More information about the babylon-dev mailing list