[code-reflection] RFR: Experiment: Alternative SSA construction algorithm
Paul Sandoz
psandoz at openjdk.org
Mon Oct 14 17:18:25 UTC 2024
On Sun, 13 Oct 2024 12:19:52 GMT, Hannes Greule <hgreule at openjdk.org> wrote:
> I experimented with moving around a few things, mainly the code in the `public void apply(Block.Builder block, Block b)` method (dealing with new block parameters) and the load situation in the second pass. Somehow I always ended up confusing myself what's mapped and what isn't. I hadn't the impression things got clearer (but maybe I went into a wrong direction). Maybe you have more concrete ideas that I missed?
Not at the moment. How about we do the following? Switch to use the new implementation, ensuring tests pass. Keep the old one too and ensure it is explicitly tested, since it is a good test case. And incrementally, if needed, update the new implementation.
>
> I also noticed that `CopyContextImpl` works recursively (in the sense of looking at parent contexts) for values but not for blocks and successors. Is that intended?
Yes, blocks can only reference other blocks from within the same body. Do you need access to a parent context?
-------------
PR Comment: https://git.openjdk.org/babylon/pull/214#issuecomment-2411824332
More information about the babylon-dev
mailing list