[code-reflection] RFR: Experiment: Alternative SSA construction algorithm

Hannes Greule hgreule at openjdk.org
Sun Oct 20 16:25:44 UTC 2024


On Mon, 14 Oct 2024 17:15:53 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

> Not at the moment. How about we do the following? Switch to use the new implementation, ensuring tests pass. Keep the old one too and ensure it is explicitly tested, since it is a good test case. And incrementally, if needed, update the new implementation.

Okay, I'll do that. Is there are way in jtreg to run tests with different system properties? This way we could just check for the property in one of the transform methods (in one of the classes) and delegate to the other depending on what was passed. This is how I tested it locally, but running tests for both this way (where they don't have different results that are relevant to the test) might make sense. WDYT?


> Yes, blocks can only reference other blocks from within the same body. Do you need access to a parent context?

I mainly was confused by the difference, without any need for it. But I also experimented with "preparing" a copy context that I then pass to the `Op#transform(CopyContext, OpTransformer)` call. That also didn't work well for other reasons, and it might be not an intended use at all, but in such scenario it would matter.

-------------

PR Comment: https://git.openjdk.org/babylon/pull/214#issuecomment-2425100469


More information about the babylon-dev mailing list