[code-reflection] RFR: ONNX FFM Runtime initial work [v3]
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Feb 10 13:12:20 UTC 2025
On Sun, 9 Feb 2025 14:31:14 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> This is initial work on ONNX FFM runtime with very raw connection with OnnxInterpreter and Tensor.
>>
>> It is a rebase of https://github.com/PaulSandoz/babylon/pull/1
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>
> minor rename
cr-examples/onnx/src/main/java/oracle/code/onnx/OnnxRuntime.java line 153:
> 151: }
> 152:
> 153: public Environment createEnv(LoggingLevel logLevel, String logId) {
There's some lifetime here to deal with... createEnv has a releaseEnv method, which is not dealt with here. Perhaps it would be convenient to associate the returned env segment with an automatic arena (Arena::ofAuto) that will be kept alive as long as the Environment instance is reachable which is, I think, what you want.
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/311#discussion_r1949026219
More information about the babylon-dev
mailing list