[code-reflection] RFR: ONNX FFM Runtime initial work [v3]

[Adam Sotona]

On Mon, 10 Feb 2025 13:09:17 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor rename
>
> cr-examples/onnx/src/main/java/oracle/code/onnx/OnnxRuntime.java line 153:
> 
>> 151:     }
>> 152: 
>> 153:     public Environment createEnv(LoggingLevel logLevel, String logId) {
> 
> There's some lifetime here to deal with... createEnv has a releaseEnv method, which is not dealt with here. Perhaps it would be convenient to associate the returned env segment with an automatic arena (Arena::ofAuto) that will be kept alive as long as the Environment instance is reachable which is, I think, what you want.

Yes, there are definitely many places for improvements. This is just a first shot to make it working ASAP.
I expect many refactoring rounds.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/311#discussion_r1949092878