[code-reflection] RFR: Support storing the code that builds the code model [v18]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Mar 26 09:53:31 UTC 2025


On Tue, 25 Mar 2025 19:44:58 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>>> We can turn opMethod into one with no param and load these fields inside its body.
>> 
>> That is what I was asking about -- while I agree what we have seems more flexible, we don't seem to use this flexibility anywhere -- as the method that turns a `Quotable` into a `Quoted` works with hardwired op and type factories. But maybe this has been already discussed -- in which case it's fine.
>
> Alternatively use a consistent the method signature with the parameters even if they are not used. Uniformity in the method signature is i think a nice property we should aim for, but could be followed up later.

Yep - I agree we can follow up later.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/305#discussion_r2013748080


More information about the babylon-dev mailing list