[code-reflection] RFR: Support storing the code that builds the code model [v18]
Paul Sandoz
psandoz at openjdk.org
Tue Mar 25 19:57:34 UTC 2025
On Wed, 19 Mar 2025 09:22:59 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> We can turn opMethod into one with no param and load these fields inside its body. But this removes the flexibility we have now (i.e. we can choose the OpFactory and TypeElementFactory we want to pass).
>
>> We can turn opMethod into one with no param and load these fields inside its body.
>
> That is what I was asking about -- while I agree what we have seems more flexible, we don't seem to use this flexibility anywhere -- as the method that turns a `Quotable` into a `Quoted` works with hardwired op and type factories. But maybe this has been already discussed -- in which case it's fine.
Alternatively use a consistent the method signature with the parameters even if they are not used. Uniformity in the method signature is i think a nice property we should aim for, but could be followed up later.
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/305#discussion_r2012825819
More information about the babylon-dev
mailing list