[code-reflection] RFR: Support storing the code that builds the code model [v18]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Mar 26 09:53:34 UTC 2025


On Tue, 25 Mar 2025 19:50:18 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>>> But I decided to have a seperate transformation as a quick fix. Later I will change the OpBuilder.
>> 
>> As stated in another comment, I'm not sure changing the op builder is needed -- as the javac code can easily workaround what the op builder does (e.g. what it does doesn't seem obviously wrong to me). But if the decision is to fix op builder that's fine too
>
> It would be nice to directly avoid changing OpBuilder (investing in a SSA to Var transformation, using liveness analysis, is probably the general right approach), but there might be a more focused approach to generating the AST so we can avoid this.

Thanks for confirming @PaulSandoz -- we can defer this improvement to a follow up change -- and keep the var-adding transformation in this PR for now.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/305#discussion_r2013743930


More information about the babylon-dev mailing list