[code-reflection] RFR: Add support for other onnx providers (CoreML) [v2]

Paul Sandoz psandoz at openjdk.org
Fri Oct 17 14:38:43 UTC 2025


On Fri, 17 Oct 2025 13:26:17 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Ana Maria Mihalceanu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update full name
>
> cr-examples/onnx/src/test/resources/oracle/code/onnx/fer/emotion-ferplus-8.onnx.data line 1:
> 
>> 1: �O:=;z�<�2I;F�޼i�=��<ӏ&�~�;.s�E J�b2���Q=��=��/�3�ڽ�FY�
> 
> We should double-check if it is OK to store 33M binary directly into the Git repo.

It's generally not ok. We should avoid committing any binary files, large or small, and instead provide instructions or a script to download such files. Especially, since this is in the Babylon repo, so everyone cloning this repo will be impacted.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/618#discussion_r2440238252


More information about the babylon-dev mailing list