[code-reflection] RFR: Add support for other onnx providers (CoreML) [v2]
Ana Maria Mihalceanu
duke at openjdk.org
Fri Oct 17 14:58:35 UTC 2025
On Fri, 17 Oct 2025 14:33:40 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> cr-examples/onnx/src/test/resources/oracle/code/onnx/fer/emotion-ferplus-8.onnx.data line 1:
>>
>>> 1: �O:=;z�<�2I;F�i�=��<ӏ&�~�;.s�E J�b2���Q=��=��/�3�ڽ�FY�
>>
>> We should double-check if it is OK to store 33M binary directly into the Git repo.
>
> It's generally not ok. We should avoid committing any binary files, large or small, and instead provide instructions or a script to download such files. Especially, since this is in the Babylon repo, so everyone cloning this repo will be impacted.
I followed the example from:
https://github.com/openjdk/babylon/tree/code-reflection/cr-examples/onnx/src/test/resources/oracle/code/onnx/mnist.
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/618#discussion_r2440300513
More information about the babylon-dev
mailing list